fix: Prevent app's bridges from overriding lastMsg prop on rooms col #29756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6fb897f The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Jul 7, 2023
KevLehman
approved these changes
Jul 7, 2023
Codecov Report
@@ Coverage Diff @@
## develop #29756 +/- ##
===========================================
- Coverage 46.62% 44.57% -2.06%
===========================================
Files 695 684 -11
Lines 13015 12824 -191
Branches 2272 2254 -18
===========================================
- Hits 6068 5716 -352
- Misses 6616 6790 +174
+ Partials 331 318 -13
Flags with carried forward coverage won't be shown. Click here to find out more. |
murtaza98
changed the title
murtaza98
changed the title
KevLehman
previously approved these changes
Jul 7, 2023
dionisio-bot
bot
added
stat: ready to merge
ggazzo
reviewed
Jul 7, 2023
d-gubert
reviewed
Jul 7, 2023
Just clarifying that it's not that the bridge was overriding the prop, it simply was not aware of it as it is a newer prop in comparison to when the bridge/converter was written. Ideally, for the future, we should consider how apps will interact with new data being added to models |
…to highlight this case
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
sampaiodiego
previously approved these changes
Jul 10, 2023
apps/meteor/app/livechat/server/hooks/saveLastVisitorMessageTs.ts
Outdated
Show resolved
Hide resolved
dionisio-bot
bot
added
stat: ready to merge
KevLehman
approved these changes
Jul 10, 2023
sampaiodiego
approved these changes
Jul 10, 2023
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jul 12, 2023
…/reportUser * 'develop' of github.com:RocketChat/Rocket.Chat: (28 commits) feat: Add missing variants to UIKit button (#29654) refactor: Remove Accountbox usage (#29786) chore: stop importing action manager as global (#29766) chore: create FeaturePreview Component (#29759) regression: add missing translations on MenuV2 replace (#29777) test: create mock package (#29765) fix: Prevent app's bridges from overriding lastMsg prop on rooms col (#29756) regression: option to start video conferences disappearing for regular users (#29763) Release 6.2.9 Revert "Release 6.2.9" fix(meteor): `room-opened` event not dispatching when navigating cached rooms (#29718) chore: device management improve readability and performance (#29712) chore: throttle exceptions counter increment (#29719) chore: Improve performance of getActiveLocalUserCount (#29681) Release 6.2.9 ci: update EE license (#29684) ci: Add missing `context` property on compose file (#29676) chore: add change stream option to get full doc (#29627) fix(meteor): Message composer keeps recording even though permission was denied (#29526) fix(meteor): Video Record button disabled on iOS browsers (#29649) ...
sampaiodiego
pushed a commit
that referenced
this pull request
Jul 13, 2023
…29756) Co-authored-by: Gabriel Casals <[email protected]> Co-authored-by: Kevin Aleman <[email protected]>
sampaiodiego
pushed a commit
that referenced
this pull request
Jul 13, 2023
…29756) Co-authored-by: Gabriel Casals <[email protected]> Co-authored-by: Kevin Aleman <[email protected]>
gabriellsh
added a commit
that referenced
this pull request
Jul 13, 2023
…reportUser * 'develop' of github.com:RocketChat/Rocket.Chat: (51 commits) feat: Add missing variants to UIKit button (#29654) refactor: Remove Accountbox usage (#29786) chore: stop importing action manager as global (#29766) chore: create FeaturePreview Component (#29759) regression: add missing translations on MenuV2 replace (#29777) test: create mock package (#29765) fix: Prevent app's bridges from overriding lastMsg prop on rooms col (#29756) regression: option to start video conferences disappearing for regular users (#29763) chore: bump fuselage packages docs: Updated README file (#29770) regression: Current Chats tags filter not showing department tags (#29758) chore: `CloudRoute` to typescript (#29762) refactor: Lazy initialization on client-side (#29764) fix: Canned Response custom tags break the GUI on enterprise (#29694) regression: fix condition to `GenericMenu` gap (#29761) test: add unit tests for feature preview hooks (#29755) chore: bump fuselage deps (#29739) refactor: Changed `getUserPreference` to `useUserPreference` on `useVoipSounds` (#29744) fix: mentions and emojis inside bold, italic and strikethrough (#29391) chore: `GenericMenu` logic to add gap (#29751) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Context: We have a prop on Room level where we store a timestamp of the visitor's last message. This prop is later used by other features of omnichannel (like Visitor abandonment feature).
Issue: The app's bridges were overriding this last msg prop due to which the features like Omnichannel Visitor Abandonment were not working. Note: this only happens if the app's bridges were involved, i.e. if we have apps which are modifying room level data (eg WhatsApp app)
Steps to test or reproduce
Further comments
PR to update Apps-engine definition -> RocketChat/Rocket.Chat.Apps-engine#645